make static const #1440
make static const #1440
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X. make static const It involves the following packages: SimRomanPot/SimFP420 @cmsbuild, @civanch, @nclopezo, @mdhildreth, @giamman can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
| @@ -39,7 +39,7 @@ void GaussNoiseProducerFP420::generate(int NumberOfchannels, | |||
| // draw noise at random according to Gaussian tail | |||
|
|
|||
| // initialise default gsl uniform generator engine | |||
| static gsl_rng * mt19937 = gsl_rng_alloc (gsl_rng_mt19937); | |||
| static const gsl_rng * mt19937 = gsl_rng_alloc (gsl_rng_mt19937); | |||
There was a problem hiding this comment.
I suggest making this
static gsl_rng const * const mt19937 = ...
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
| @@ -39,7 +39,7 @@ void GaussNoiseProducerFP420::generate(int NumberOfchannels, | |||
| // draw noise at random according to Gaussian tail | |||
|
|
|||
| // initialise default gsl uniform generator engine | |||
| static gsl_rng * mt19937 = gsl_rng_alloc (gsl_rng_mt19937); | |||
| static gsl_rng const * mt19937 = gsl_rng_alloc (gsl_rng_mt19937); | |||
There was a problem hiding this comment.
Sorry, I should have said make this
static gsl_rng const * const mt19937 = ...
|
Looks good to me |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Multithreading fixes -- Make a static const in SimRomanPot/SimFP420
No description provided.