Add DQMStore::getElement whichs throws an exception instead of a nullptr (80x) #14407
Conversation
…ptr. Half of DQM software does not check for nullptrs when retrieving histograms. This usually causes a segfault and a few minute wait for gdb to produce the stacktrace. Crashing the framework with an out-of-bounds exception is better and more clean. Also fixes DQM/SiPixelMonitorClient which would segfault online on every empty run. It still crashes, but in a 'nicer' way.
|
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_8_0_X. It involves the following packages: DQM/SiPixelMonitorClient @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
dmitrijus
changed the title
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison is ready The workflows 1003.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
+1 |
Add DQMStore::getElement whichs throws an exception instead of a nullptr (80x)
Half of DQM software does not check for nullptrs when retrieving histograms.
This usually causes a segfault and a few minute wait for gdb to produce the stacktrace.
Crashing the framework with an out-of-bounds exception is better and
more clean.
Also fixes DQM/SiPixelMonitorClient which would segfault online on
every empty run. It still crashes, but in a 'nicer' way.