make static into class members #1441
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X. make static into class members It involves the following packages: Validation/TrackerHits @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please review it and eventually sign? Thanks. |
|
|
||
|
|
||
| std::string HepMClabel = config_.getUntrackedParameter<std::string>("HepMCProductLabel","source"); | ||
| std::string HepMCinstance = config_.getUntrackedParameter<std::string>("HepMCInputInstance",""); |
There was a problem hiding this comment.
This won't work right. This declares a new variable with the same name as the member data. You need to remove the std::string in both lines.
| @@ -138,6 +138,9 @@ class TrackerHitProducer : public edm::EDProducer | |||
| edm::InputTag G4TrkSrc_; | |||
|
|
|||
| edm::ParameterSet config_; | |||
| std::string HepMClabel; | |||
| std::string HepMCinstance; | |||
There was a problem hiding this comment.
To make it consistent with the other member data, could these names be changed to end with an underscore?
|
Looks good to me. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Multithreading fixes -- Make static into class members
No description provided.