Updating to HLT paths to be monitored by TOP PAG in 2016 in 81X #14410
Conversation
|
A new Pull Request was created by @Soureek89 (Soureek Mitra) for CMSSW_8_1_X. It involves the following packages: DQMOffline/Trigger @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
80x: #14367 |
| pathsDIELEC = cms.vstring([ 'HLT_Ele23_Ele12_CaloIdL_TrackIdL_IsoVL_DZ_v', | ||
| 'HLT_Ele23_Ele12_CaloIdL_TrackIdL_IsoVL_v']) | ||
| ) | ||
| src = cms.InputTag("TriggerResults","","HLT"), |
There was a problem hiding this comment.
Please don't use tabs in python. Especially not if the rest of the file uses spaces.
|
Please fix spaces/tabs in python files. In cpp compiler ignores whitespace, but in python this can lead to severe issues (since whitespace is used for blocks). |
|
I am making changes to remove tabs and trying to commit them to the same branch. |
|
Pull request #14410 was updated. @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please check and sign again. |
|
Hello I have updated the branch by removing tabs according to the comments received. Can you please approve? |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
comparison-pending
tests-started
and removed
comparison-available
tests-approved
tests-pending
labels
|
+1 |
Removing Lepton + btags/jets triggers from the list of triggers as the TOP PAG does not intend to monitor them further in 2016. The reason being these triggers are not being used in TOP analyses. Also adding token for "hltTriggerSummaryAOD" collection present in both data and MC. Replaced "cout" commands with edm::LogWarning. The code is tested to be Ok by running the matrix for TTbar_13 workflow for 25ns bunch spacing.