Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dqm 81 x test pf candidate after rebase #14422

Merged

Conversation

webermat
Copy link
Contributor

@webermat webermat commented May 9, 2016

this PR is the rebased version of the PR in
#13587

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

A new Pull Request was created by @webermat for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/JetMET

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@webermat
Copy link
Contributor Author

webermat commented Jun 7, 2016

if this PR could be tested

@dmitrijus
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13393/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

@webermat
Copy link
Contributor Author

webermat commented Jun 8, 2016

comparisons are fine

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 72c0c6b into cms-sw:CMSSW_8_1_X Sep 2, 2016
@slava77
Copy link
Contributor

slava77 commented Sep 2, 2016

@slava77
Copy link
Contributor

slava77 commented Sep 2, 2016

@davidlange6
if there is no quick fix in a day or so, may I suggest to revert this PR

@slava77
Copy link
Contributor

slava77 commented Sep 2, 2016

actually, on a more complete build many more workflows fail

The plugin 'PFCandidateAnalyzer' is found in multiple files 
 '"pluginDQMOfflineJetMET.so"'
 '"pluginPFCandidateAnalyzer.so"'

@davidlange6 please revert this ASAP

@davidlange6
Copy link
Contributor

Done. Thanks for the confirmation of what I had hoped to check this am..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants