Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

76x Fireworks:Update table view content #14485

Merged
merged 15 commits into from May 17, 2016
Merged

76x Fireworks:Update table view content #14485

merged 15 commits into from May 17, 2016

Conversation

alja
Copy link
Contributor

@alja alja commented May 12, 2016

No description provided.

alja added 13 commits May 12, 2016 11:14
@alja
Inlude -n option when cmsShow is started with data file.
5420100
@alja
allow default reco::Jet table entries content.
9242c29
@alja
Disable gowth in width.
d2343f7
@alja
Add default columns for pat::packedCandidate.
c10ea14 
Conflicts:
	Fireworks/Core/src/FWTableViewManager.cc
@alja
Add default columns for reco::Electron.
12785ec 
Conflicts:
	Fireworks/Core/src/FWTableViewManager.cc
@alja
Add new column for reco::PFCandidate.
76c27de 
Conflicts:
	Fireworks/Core/src/FWTableViewManager.cc
@alja
Update reco::pfCandidate table entries.
89b4330 
Conflicts:
	Fireworks/Core/src/FWTableViewManager.cc
@alja
Allow default table entries.
658ddcb 
Conflicts:
	Fireworks/Core/macros/reco.fwc
@alja
New default entries for reco::Jet.
796e899
@alja
New default entries for reco::Jet.
db87ce6
@alja
Fix merge conflicts.
98b959e
@alja
resolve merge conflicts.
410a12a
@alja
remove obsolete assert.
433f93a
@alja
Copy link
Contributor Author

alja commented May 12, 2016

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone May 12, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12958/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_6_X.

It involves the following packages:

Fireworks/Core

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@alja
Copy link
Contributor Author

alja commented May 12, 2016

-1 need time for more tests

@cmsbuild
Copy link
Contributor

+1
Tested at: 433f93a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14485/12958/summary.html

@alja
Change setting for reco::Jet type.
d01349c 
Conflicts:
	Fireworks/Core/src/FWTableViewManager.cc
@cmsbuild
Copy link
Contributor

Pull request #14485 was updated. @cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please check and sign again.

@alja
Copy link
Contributor Author

alja commented May 16, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13006/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

+1
Tested at: d01349c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14485/13006/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b353471 into cms-sw:CMSSW_7_6_X May 17, 2016
@alja alja deleted the tableconfig76 branch May 11, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed orp-approved tests-approved visualization-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alja @cmsbuild @davidlange6