Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL DQM Updates. On top of 13805 #14491

Merged

Conversation

vkhristenko
Copy link
Contributor

To fix the problem that came up during rel val testing for 13805!

My apology for this!

@dmitrijus

VK

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vkhristenko (Viktor Khristenko) for CMSSW_8_1_X.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

Fixes: #13805
( Adding a reference, so I can click around easily. )

@vkhristenko
Copy link
Contributor Author

ah, yeah, sorry..... thanks for bringing up!

@dmitrijus
Copy link
Contributor

+1
Looks like you just copied those files from 80x and made a single commit.
I don't mind that, but I believe more optimal way would be to use cherry-pick - it's way easier for me to verify if commits match :)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12969/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9ec3325 into cms-sw:CMSSW_8_1_X May 13, 2016
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants