New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Pythia8Interface to pythia8 219 #14496
Conversation
A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for CMSSW_8_1_X. It involves the following packages: GeneratorInterface/Pythia8Interface @covarell, @perrozzi, @thuer, @cmsbuild, @davidlange6, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
This is compatible with the current pythia8 |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
please test with cms-sw/cmsdist#2294 |
The tests are being triggered in jenkins. |
-1 Tested at: cad0fe0 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testRecoMETMETProducers had ERRORS |
please test with cms-sw/cmsdist#2294 |
The tests are being triggered in jenkins. |
I retried tests because I could not figure out what the problem is and want to see if it is transient... |
the error was unrelated |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
-1 Tested at: cad0fe0 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/JetMETCorrections/MCJet/bin/ResponseFitter.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/JetMETCorrections/MCJet/bin/L2Correction.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/JetMETCorrections/MCJet/bin/L3Correction.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/JetMETCorrections/MCJet/bin/ReadTree.cc /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc: In member function 'void clangcms::FiniteMathChecker::checkPreStmt(const clang::CallExpr*, clang::ento::CheckerContext&) const': /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc:33:51: error: no matching function for call to 'clang::ento::CheckerContext::generateSink()' clang::ento::ExplodedNode *N = ctx.generateSink(); ^ /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc:33:51: note: candidate is: In file included from /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.h:5:0, from /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc:1: |
No description provided.