Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Pythia8Interface to pythia8 219 #14496

Merged
merged 1 commit into from May 18, 2016

Conversation

mkirsano
Copy link
Contributor

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone May 13, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for CMSSW_8_1_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@covarell, @perrozzi, @thuer, @cmsbuild, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@agrohsje this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mkirsano
Copy link
Contributor Author

This is compatible with the current pythia8

@govoni
Copy link
Contributor

govoni commented May 13, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12983/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ghost
Copy link

ghost commented May 16, 2016

please test with cms-sw/cmsdist#2294

@cmsbuild
Copy link
Contributor

-1

Tested at: cad0fe0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14496/45/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

@cmsbuild
Copy link
Contributor

@covarell
Copy link
Contributor

please test with cms-sw/cmsdist#2294

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2016

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2294
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/46/console

@covarell
Copy link
Contributor

I retried tests because I could not figure out what the problem is and want to see if it is transient...

@davidlange6
Copy link
Contributor

the error was unrelated

@davidlange6 davidlange6 merged commit 19c1cf4 into cms-sw:CMSSW_8_1_X May 18, 2016
@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

-1

Tested at: cad0fe0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14496/46/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/JetMETCorrections/MCJet/bin/ResponseFitter.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/JetMETCorrections/MCJet/bin/L2Correction.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/JetMETCorrections/MCJet/bin/L3Correction.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/JetMETCorrections/MCJet/bin/ReadTree.cc 
/build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc: In member function 'void clangcms::FiniteMathChecker::checkPreStmt(const clang::CallExpr*, clang::ento::CheckerContext&) const':
/build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc:33:51: error: no matching function for call to 'clang::ento::CheckerContext::generateSink()'
   clang::ento::ExplodedNode *N = ctx.generateSink();
                                                   ^
/build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc:33:51: note: candidate is:
In file included from /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.h:5:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc:1:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants