Muon analysis updates 8.1.x #14511
Muon analysis updates 8.1.x #14511
Conversation
(and same for offline validation plots in a simpler way) Conflicts: Alignment/OfflineValidation/python/TkAlAllInOneTool/configTemplates.py
|
A new Pull Request was created by @usarica (Ulascan Sarica) for CMSSW_8_1_X. It involves the following packages: Alignment/OfflineValidation @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
| @@ -88,7 +88,6 @@ void PlotAlignmentValidation::useFitForDMRplots(bool usefit) | |||
| //------------------------------------------------------------------------------ | |||
| void PlotAlignmentValidation::setOutputDir( std::string dir ) | |||
| { | |||
| // we should check if this dir exsits... | |||
| std::cout <<"'"<< outputDir <<"' = "<< dir << std::endl; | |||
There was a problem hiding this comment.
@usarica Naive question: do you check if the directory exists?
There was a problem hiding this comment.
2 lines down I do mkdir (and 2nd argument=true means -p)
|
@usarica In addition to my inline comments: |
|
@ghellwig The PR fixes the mu+ mu- ordering, most relevant for applying asymmetric eta cuts. It was actually used in the Run 2015 EOY validations but was never propagated due to previous Zmumu PRs pending at that time (one is still pending). |
|
+1 |
No description provided.