Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statistics of Trend plots #14518

Merged
merged 2 commits into from May 25, 2016

Conversation

mbandrews
Copy link
Contributor

@mbandrews mbandrews commented May 16, 2016

Fix Presample and Timing Trend plots

  • Create new set of Task MEs that only contain statistics from "current LS" which the Client Trend plots will analyze
  • Define "current LS" = 10 LSs (10 LSs = 1 pt in the Trend plots) and we want to collect sufficient stats so that different channels are well-represented beyond the minChannelEntries threshold
  • Include a filter to exclude channels with status other than EcalChannelStatusCode::kOk.
  • Previously, Trend plots were using cumulative statistics causing noisy channels to accumulate enough stats to bias trend which resulted in "jumping" phenomenon after plot resets
  • See 80X PR Fix statistics of Trend plots #14517

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbandrews (Michael Andrews) for CMSSW_8_1_X.

It involves the following packages:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mbandrews
Copy link
Contributor Author

Added a commit to use EcalChannelStatusCode::kOk instead of '0'.

@dmitrijus
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13051/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants