Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include full alignment and APE for Pixel Phase-I detector #14545

Merged
merged 2 commits into from May 19, 2016
Merged

Include full alignment and APE for Pixel Phase-I detector #14545

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
714d66e
Include full alignment and APE for Pixel Phase-I detector
mmusich May 18, 2016
16c3b2c
removing alignment override customization
mmusich May 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Configuration/AlCa/python/autoCond.py
View file
Open in desktop
Expand Up @@ -34,9 +34,9 @@
# GlobalTag for Run2 HLT for HI: it points to the online GT
'run2_hlt_hi' : '80X_dataRun2_HLTHI_frozen_v9',
# GlobalTag for MC production with perfectly aligned and calibrated detector for Phase1 2017
'phase1_2017_design' : '80X_upgrade2017_design_v12',
'phase1_2017_design' : '80X_upgrade2017_design_v13',
# GlobalTag for MC production with realistic conditions for for Phase1 2017 detector
'phase1_2017_realistic': '80X_upgrade2017_realistic_v4',
'phase1_2017_realistic': '80X_upgrade2017_realistic_v5',
# GlobalTag for MC production with perfectly aligned and calibrated detector for Phase1 2019
'phase1_2019_design' : 'DES19_70_V2', # placeholder (GT not meant for standard RelVal)
# GlobalTag for MC production with perfectly aligned and calibrated detector for Phase2
Expand Down
2 changes: 1 addition & 1 deletion Configuration/Geometry/python/GeometryExtended2017Reco_cff.py
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
from Geometry.TrackerGeometryBuilder.idealForDigiTrackerGeometry_cff import *
from Geometry.CSCGeometryBuilder.idealForDigiCscGeometry_cff import *
from Geometry.DTGeometryBuilder.idealForDigiDtGeometry_cff import *
trackerGeometry.applyAlignment = cms.bool(False)
trackerGeometry.applyAlignment = cms.bool(True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest to just remove this override instead (I think it would be more clear)? The default is True https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/Geometry/TrackerGeometryBuilder/plugins/TrackerDigiGeometryESModule.cc#L64.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makortel done in the latest commit


# Calorimeters
from Geometry.CaloEventSetup.CaloTopology_cfi import *
Expand Down
2 changes: 1 addition & 1 deletion Configuration/Geometry/python/GeometryExtended2017devReco_cff.py
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
from Geometry.TrackerGeometryBuilder.idealForDigiTrackerGeometry_cff import *
from Geometry.CSCGeometryBuilder.idealForDigiCscGeometry_cff import *
from Geometry.DTGeometryBuilder.idealForDigiDtGeometry_cff import *
trackerGeometry.applyAlignment = cms.bool(False)
trackerGeometry.applyAlignment = cms.bool(True)

# Calorimeters
from Geometry.CaloEventSetup.CaloTopology_cfi import *
Expand Down