CondCore/PopCon: define static constexpr member #14563
Conversation
The patch resolves issue with Clang compiler.
N3690 (should be C++11 standard) and latest draft N4567, 9.4.2/3
...
The member shall still be defined in a namespace scope if it
is odr-used (3.2) in the program and the namespace scope definition
shall not contain an initializer.
9.4.2/4 talks about how const static data members are being handled.
Also standard says that no diagnostic is required by compiler.
src/CondCore/PopCon/src/CondCorePopCon/PopCon.o: In function 'popcon::PopCon::PopCon(edm::ParameterSet const&)':
src/CondCore/PopCon/src/PopCon.cc:(.text+0x274): undefined reference to 'popcon::PopCon::s_version'
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_8_1_X. It involves the following packages: CondCore/PopCon @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
The patch resolves issue with Clang compiler.
N3690 (should be C++11 standard) and latest draft N4567, 9.4.2/3
...
The member shall still be defined in a namespace scope if it
is odr-used (3.2) in the program and the namespace scope definition
shall not contain an initializer.
9.4.2/4 talks about how const static data members are being handled.
Also standard says that no diagnostic is required by compiler.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch