Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new detectors - integration of RomanPot detectors for CTPPS project - backport of PR #13766 #14578

Merged
merged 2 commits into from May 22, 2016

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented May 19, 2016

This a backport of #13766 from CMSSW 8_1_X

Integration of RomanPot (RP) detectors for CTPPS.
DetId=7 refers to the standard sequence of Totem RP + Si Strips sensors.
These detectors are required in the early runs of CTPPS (2016 start of run).
DetId=8 refers to the baseline setup of CTPPS with new 3D pixel sensors (operative end of 2016)
and Timing sensors (operative mid 2016) installed in a new Roman Pot.

The reason to have two DetId is to avoid possible clashes

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @grzanka (Leszek Grzanka) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/DetId

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 19, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13092/console

@cmsbuild
Copy link
Contributor

-1

Tested at: e9b894a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14578/13092/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestSimCalorimetryHGCalSimProducers had ERRORS
---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 20, 2016

@davidlange6
please merge this sooner since it's blocking tests of other PRs.
If consolidation of PRs will be better, please clarify in this case.

@civanch
Copy link
Contributor

civanch commented May 20, 2016

+1
unit tests crashes seems not related to this PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants