Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use full geometry cffs for MB plotting scripts #14584

Merged
merged 1 commit into from May 25, 2016
Merged

use full geometry cffs for MB plotting scripts #14584

merged 1 commit into from May 25, 2016

Conversation

friccita
Copy link
Contributor

Cosmetic changes to python scripts for producing tracker material budget plots:

  • in runP_Tracker_cfg.py, the default value for maxEvents is set to -1
  • instead of individually loading geometry config files in every python script, the full geometry cff for Phase 1 is loaded instead

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone May 20, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @friccita (Francesca Ricci-Tam) for CMSSW_8_1_X.

It involves the following packages:

Validation/Geometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @deguio, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

ianna
ianna reviewed May 24, 2016
View reviewed changes
Validation/Geometry/test/runP_Tracker_cfg.py
process.load("Geometry.HcalCommonData.hcalParameters_cfi")
process.load("Geometry.HcalCommonData.hcalDDDSimConstants_cfi")
process.load("Configuration.Geometry.GeometryExtended2017_cff")
#process.load("Geometry.CMSCommonData.cmsExtendedGeometry2017XML_cfi")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@friccita - it's probably better to remove commented out lines.

@ianna
Copy link
Contributor

ianna commented May 24, 2016

please test

@ianna
Copy link
Contributor

ianna commented May 24, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13152/console

@cmsbuild
Copy link
Contributor

+1
Tested at: cf7c8c9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14584/13152/summary.html

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6 davidlange6 merged commit a9fefff into cms-sw:CMSSW_8_1_X May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending dqm-approved fully-signed geometry-approved orp-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@friccita @cmsbuild @ianna @dmitrijus @davidlange6