Fix deltaR calculation in HLT widejet module #14587
Conversation
|
A new Pull Request was created by @duanders (Dustin Anderson) for CMSSW_8_0_X. It involves the following packages: HLTrigger/JetMET @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
need a 81X PR as well! |
|
The tests are being triggered in jenkins. |
| @@ -128,11 +129,11 @@ HLTFatJetMassFilter<jetType>::hltFilter(edm::Event& iEvent, const edm::EventSetu | |||
|
|
|||
| // apply radiation recovery | |||
| for ( recojet = recojets.begin() ; recojet != recojets.end() ; recojet++) { | |||
| double DeltaR1 = sqrt(pow(recojet->phi()-j1.phi(), 2.)+pow(recojet->eta()-j1.eta(),2.)); | |||
| double DeltaR2 = sqrt(pow(recojet->phi()-j2.phi(), 2.)+pow(recojet->eta()-j2.eta(),2.)); | |||
| if(DeltaR1 < DeltaR2 && DeltaR1 < fatJetDeltaR_) { | |||
|
+1 |
|
I think this should be simple and safe enough to enter directly as bugfix in 8.0.x - @davidlange6 what do you say ? |
cmsbuild
added
hlt-approved
fully-signed
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
it can go into 80x, but would like an 81x request too. (also for the second request from @duanders ) |
Modifies HLTFatJetMassFilter so that it computes DeltaR correctly. (The current behavior does not treat DeltaPhi modulo 2 pi.)