Latest MillePede fixes 81X #14592
Merged
Latest MillePede fixes 81X #14592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghellwig
commented
May 20, 2016
•
ghellwig
commented
- miscellaneous fixes the MP production system
- subtract APEs to retrieve CPE-only covariance matrix (d9233ca)
- removes bias on fit procedure due to different APEs in different subdetectors
- added also a switch to get old behaviour (59415e5)
- needed for very large misalignments
- fix invalid read in ReferenceTrajectory class (be2e790)
- fix bug causing rare random mille binary corruption (69b4a89)
- use BrokenLinesBzeroTrajectoryFactory - change the MomentumEstimate to 5 GeV (as in 0T Reco)
This protects against the case where one accidentally removes the campaign list w/o recovering the file from the backup before the next campaign is created.
- moved the general setup in separate function -> universal config template is adapted accordingly
- moved the loading of the alignment producer default settings to the corresponding function - more reasonable example for condition override
- was a remnant from static memory allocation in pede - since a while, 'pede' allocates its memory dynamically
- clean-up of universal config template: - untabify - delete trailing whitespace
- adapt to the changes first proposed in https://hypernews.cern.ch/HyperNews/CMS/get/recoTracking/1415.html
- added constructors accepting those structs
-> currently delegating to the old constructors
- next steps:
- modify the code calling the trajectory constructors to use the new
constructors
- move code of old constructors to new ones and delete the old ones
next step: - move code of old constructors to new ones and delete the old ones
…mbers. - clean up of 'construct' method to which those parameters were forwarded
In case of 1D measurements the old code was accessing memory out of bounds for 'localPosition' and 'projectedJacobian'.
- wrap raw pointers whose objects are owned by 'MillePedeAlignmentAlgorithm' in 'unique_ptr's - fixes also a bug in writing the MilleBinary -> the object's destructor is never called because of a missing delete
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
+1 |
davidlange6
added a commit
that referenced
this pull request
May 31, 2016
Latest MillePede fixes 80X (backport of #14592)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.