Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OMTF treatment of Muons at edge of OMTF acceptance #14613

Merged
merged 3 commits into from May 24, 2016
Merged

Update OMTF treatment of Muons at edge of OMTF acceptance #14613

merged 3 commits into from May 24, 2016

Conversation

mulhearn
Copy link
Contributor

This is 80x version of #14604.

konec added 3 commits May 24, 2016 10:59
@konec @mulhearn
assigne eta=+-121 to CSC hits with keyWG above |eta|=1.3, then filter…
e9af775 
… them

set q=4 to muons with |eta|=115,
remove layers 7,8,9 from list of layers with q-4
minor fixes to CSC keywire group assignment to eta code
@konec @mulhearn
slightly tune/modify condition of q=4 for |eta|==115.
b1919a8 
Now it is done if in case |eta|==115 and hits are ONLY in 3 layers out of (7,8,9,17)
@konec @mulhearn
In case of |eta| 121 set its quality to 4.
5971e82 
It has no effect for MC shince hits with this quality are filtered out, but
is usefull for data-MC comparistion (if one remove the filter)
@mulhearn
Copy link
Contributor Author

please test

@mulhearn
Copy link
Contributor Author

+1

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone May 24, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13147/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

L1Trigger/L1TMuonOverlap

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn mulhearn mentioned this pull request May 24, 2016
Open
@cmsbuild
Copy link
Contributor

+1
Tested at: 5971e82
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14613/13147/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d43f4f0
65bbbc6
0574bf0
12439ff
9a045ea
7ca714b
7fa7243
95c293c
4f6c2ca
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14613/13147/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14613/13147/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14613/13147/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5699c34 into cms-sw:CMSSW_8_0_X May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mulhearn @cmsbuild @davidlange6 @konec