Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removal of statics from FastSimulation/Event/interface/FBaseSimEvent.icc #1462

Merged
merged 1 commit into from Nov 14, 2013
Merged

removal of statics from FastSimulation/Event/interface/FBaseSimEvent.icc #1462

merged 1 commit into from Nov 14, 2013

Commits on Nov 14, 2013

  1. removal of statics from FastSimulation/Event/interface/FBaseSimEvent.icc

    I removed the definition of static FSimTrack, FSimVertex and FSimVertexType.
    These statics used to be returned by functions track(int i), vertex(int i), vertexType(int i) in case the index i was out of range.
    Now instead an error is thrown.
    To avoid indices out of range, a number of changes were made
    
    * interface/FSimTrack.icc
    
    The function FSimTrack::noEndVertex() now first of all checks if FSimTrack has an end vertex
    (index of end vertex >= 0)
    associated and returns false if this is not the case.
    
    FSimtrack::nDaughters() returns 0 if the thrack has no daughter
    
    To ease future debugging, errors are thrown when
    - FSimTrack::mother() is called for tracks w/o mother
    - FSimTrack::endVertex() is called for tracks w/o mother
    - FSimTrack::daugther(int i) is called with i out of range
    - FSimTrack::daughters() is called for track w/o end vertex
    
    * src/FSimEvent.cc
    
    The function FSimEvent::load(edm::SimTrackContainer & c, edm::SimTrackContainer & m)
    now verifies wether a track has a mother (index mother >= 0)
    before evaluating the properties of the mother.
    
    * FastSimulation/TrajectoryManager/src/TrajectoryManager.cc
    
    avoided the call of FSimTrack::mother() for tracks w/o mother
    
    ** Tests:
    runTheMatrix.py -l 5.1,401.0
    Lukas committed Nov 14, 2013
    Copy the full SHA
    74194b1 View commit details
    Browse the repository at this point in the history