Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fireworks Gem and me0 segments 81x #14656

Merged
merged 4 commits into from May 28, 2016

Conversation

jshlee
Copy link
Contributor

@jshlee jshlee commented May 27, 2016

added gem superchambers to fireworks geometry maker
added FWGEMSegmentProxyBuilder
added FWME0RecHitProxyBuilder
added FWME0SegmentProxyBuilder
added gem and me0 to SegmentUtils

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jshlee (Jason Lee) for CMSSW_8_1_X.

It involves the following packages:

Fireworks/Geometry
Fireworks/Muons

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13235/console

@cmsbuild
Copy link
Contributor

@alja
Copy link
Contributor

alja commented May 27, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7a393ea into cms-sw:CMSSW_8_1_X May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants