Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bounds check on an array index. #1468

Merged

Conversation

kknb1056
Copy link

Added a bounds check on an array index (line 550). This only shows up with changes David Dagenhart made on another branch, but should still have the check in the main tree.
Some array indexing was also fixed (line 518), although this line is a safe-guard that I don't expect to ever be invoked anyway (see comment in the line above). Even so the indexing should be corrected anyway.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kknb1056 (Mark Grimes) for CMSSW_7_0_X.

Added bounds check on an array index.

It involves the following packages:

SimGeneral/TrackingAnalysis

@cmsbuild, @civanch, @nclopezo, @mdhildreth, @giamman can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@civanch
Copy link
Contributor

civanch commented Nov 14, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 15, 2013
…rticleIndexFix

Sim bug fix -- Added bounds check on an array index.
@ktf ktf merged commit e9c626f into cms-sw:CMSSW_7_0_X Nov 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants