Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing max updates limit (DAQ) 81X #14688

Merged
merged 1 commit into from Jun 1, 2016

Conversation

smorovic
Copy link
Contributor

Removes limit to number of updates that are taken with 1 Hz. This is currently limiting measurement of processes stuck for a long time.
Same as 80X #14687

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_8_1_X.

It involves the following packages:

EventFilter/Utilities

@cvuosalo, @emeschi, @cmsbuild, @slava77, @mommsen, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mommsen
Copy link
Contributor

mommsen commented May 30, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13262/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 404a482

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14688/13262/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step1

DAS Error

@cvuosalo
Copy link
Contributor

@cmsbuild please test
Try again in hopes DAS error won't repeat

@cmsbuild
Copy link
Contributor

cmsbuild commented May 31, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13291/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #14688 404a482

Very small change that removes the limit on the number of updates per lumi. There should be no change in monitored quantities.

#14687 is the 80X version of this PR, and it has already been approved.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-05-29-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cfc7eae into cms-sw:CMSSW_8_1_X Jun 1, 2016
@smorovic smorovic deleted the maxupdates-81X branch February 13, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants