New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing max updates limit (DAQ) 81X #14688
Conversation
A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_8_1_X. It involves the following packages: EventFilter/Utilities @cvuosalo, @emeschi, @cmsbuild, @slava77, @mommsen, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
+1 |
The tests are being triggered in jenkins. |
-1 Tested at: 404a482 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Very small change that removes the limit on the number of updates per lumi. There should be no change in monitored quantities. #14687 is the 80X version of this PR, and it has already been approved. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-05-29-2300 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Removes limit to number of updates that are taken with 1 Hz. This is currently limiting measurement of processes stuck for a long time.
Same as 80X #14687