CTPPS: DQM for TOTEM RP - backport of #14034 #14696

grzanka · 2016-05-31T07:33:28Z

Backport of PR #14034 from CMSSW 81X

The code will not compile as it depends on many features not yet integrated in CMSSW. I'm issuing the PR so as people can start looking at the code. Compilable code is available in the CTPPS repository:
https://github.com/CTPPS/ctpps-offline.

…module added.

cmsbuild · 2016-05-31T07:33:44Z

A new Pull Request was created by @grzanka (Leszek Grzanka) for CMSSW_8_0_X.

It involves the following packages:

DQM/CTPPS

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-05-31T12:43:43Z

@cmsbuild please test

cmsbuild · 2016-05-31T12:44:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13278/console

dmitrijus · 2016-05-31T12:54:14Z

+1

cmsbuild · 2016-05-31T12:54:33Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2016-05-31T14:25:49Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2016-05-31T14:26:31Z

-1

Tested at: 656c12e

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
bc82047
0bf418a
d4a4144
ba46a23
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14696/13278/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14696/13278/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14696/13278/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/MuonAnalysis/MuonAssociators/src/MatcherUsingTracksAlgorithm.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/MuonAnalysis/MuonAssociators/src/MatcherByPullsAlgorithm.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/MuonAnalysis/MuonAssociators/plugins/MatcherByPulls.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/MuonAnalysis/MuonAssociators/plugins/MuonMCClassifier.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/MuonAnalysis/MuonAssociators/plugins/HLTL1MuonMatcher.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/DQM/CTPPS/plugins/TotemDAQTriggerDQMSource.cc:21:58: fatal error: DataFormats/TotemDigi/interface/TotemFEDInfo.h: No such file or directory
compilation terminated.
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/DQM/CTPPS/plugins/TotemRPDQMSource.cc:31:70: fatal error: Geometry/Records/interface/VeryForwardRealGeometryRecord.h: No such file or directory
compilation terminated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/MuonAnalysis/MuonAssociators/plugins/TriggerObjectFilterByCollection.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/MuonAnalysis/MuonAssociators/plugins/MatcherUsingTracks.cc

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

1 warning generated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/L1Trigger/L1TGlobal/plugins/L1TUtmTriggerMenuESProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/L1Trigger/L1TGlobal/plugins/BXVectorInputProducer.cc 
1 warning generated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/L1Trigger/L1TGlobal/plugins/L1TGlobalSummary.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/DQM/CTPPS/plugins/TotemDAQTriggerDQMSource.cc:21:10: fatal error: 'DataFormats/TotemDigi/interface/TotemFEDInfo.h' file not found
#include "DataFormats/TotemDigi/interface/TotemFEDInfo.h"
         ^
1 error generated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/DQM/CTPPS/plugins/TotemRPDQMSource.cc:31:10: fatal error: 'Geometry/Records/interface/VeryForwardRealGeometryRecord.h' file not found

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
bc82047
0bf418a
d4a4144
ba46a23
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14696/13278/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14696/13278/git-merge-result

dmitrijus · 2016-05-31T14:33:23Z

please align this with 81x (to make it compile-able)

grzanka · 2016-05-31T15:26:15Z

@dmitrijus what do you mean by aligning it with 81x ? it is an exact copy of PR which was merged in 81x.

dmitrijus · 2016-05-31T15:34:46Z

@grzanka Oh, sorry, you are right - these are the same commits as 81x PR.
However, it needs to compile first before it can be included.

I guess this dependency-PR (#14630) is missing from 80x.

dmitrijus · 2016-05-31T15:34:50Z

hold

cmsbuild · 2016-05-31T15:35:05Z

Pull request has been put on hold by @dmitrijus
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild · 2016-06-17T09:27:02Z

Pull request #14696 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

grzanka · 2016-06-17T11:04:11Z

@davidlange6 @slava77 could you please cross-check ?

davidlange6 · 2016-06-17T11:15:55Z

please test

On Jun 17, 2016, at 1:04 PM, Leszek Grzanka notifications@github.com wrote:

@davidlange6 @slava77 could you please cross-check ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

cmsbuild · 2016-06-17T11:17:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13574/console

dmitrijus · 2016-06-17T12:24:19Z

+1

cmsbuild · 2016-06-17T12:24:40Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2016-06-17T13:04:52Z

+1
Tested at: 9614245
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14696/13574/summary.html

cmsbuild · 2016-06-17T14:02:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14696/13574/summary.html

davidlange6 · 2016-06-20T07:52:43Z

+1

jan-kaspar added 3 commits May 30, 2016 22:58

Initial import from CTPPS repository.

04ad1f4

Update after merging DataFormats/CTPPSReco, TotemDAQTriggerDQMSource …

d37842f

…module added.

After tests with first LHC data.

656c12e

cmsbuild added this to the Next CMSSW_8_0_X milestone May 31, 2016

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending comparison-pending labels May 31, 2016

cmsbuild added tests-started and removed tests-pending labels May 31, 2016

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 31, 2016

cmsbuild added tests-rejected and removed tests-started labels May 31, 2016

cmsbuild removed the fully-signed label May 31, 2016

cmsbuild added dqm-pending pending-signatures tests-pending comparison-pending and removed dqm-approved fully-signed tests-approved labels Jun 17, 2016

cmsbuild added tests-started and removed tests-pending labels Jun 17, 2016

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 17, 2016

cmsbuild added tests-approved and removed tests-started labels Jun 17, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jun 17, 2016

cmsbuild added orp-approved and removed orp-pending labels Jun 20, 2016

cmsbuild merged commit bef50b5 into cms-sw:CMSSW_8_0_X Jun 20, 2016

jan-kaspar deleted the ctpps_dqm_backport branch October 24, 2017 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CTPPS: DQM for TOTEM RP - backport of #14034 #14696

CTPPS: DQM for TOTEM RP - backport of #14034 #14696

grzanka commented May 31, 2016

cmsbuild commented May 31, 2016

slava77 commented May 31, 2016

cmsbuild commented May 31, 2016 •

edited

dmitrijus commented May 31, 2016

cmsbuild commented May 31, 2016

cmsbuild commented May 31, 2016

cmsbuild commented May 31, 2016

dmitrijus commented May 31, 2016

grzanka commented May 31, 2016

dmitrijus commented May 31, 2016

dmitrijus commented May 31, 2016

cmsbuild commented May 31, 2016

cmsbuild commented Jun 17, 2016

grzanka commented Jun 17, 2016

davidlange6 commented Jun 17, 2016

cmsbuild commented Jun 17, 2016 •

edited

dmitrijus commented Jun 17, 2016

cmsbuild commented Jun 17, 2016

cmsbuild commented Jun 17, 2016

cmsbuild commented Jun 17, 2016

davidlange6 commented Jun 20, 2016

CTPPS: DQM for TOTEM RP - backport of #14034 #14696

CTPPS: DQM for TOTEM RP - backport of #14034 #14696

Conversation

grzanka commented May 31, 2016

cmsbuild commented May 31, 2016

slava77 commented May 31, 2016

cmsbuild commented May 31, 2016 • edited

dmitrijus commented May 31, 2016

cmsbuild commented May 31, 2016

cmsbuild commented May 31, 2016

cmsbuild commented May 31, 2016

dmitrijus commented May 31, 2016

grzanka commented May 31, 2016

dmitrijus commented May 31, 2016

dmitrijus commented May 31, 2016

cmsbuild commented May 31, 2016

cmsbuild commented Jun 17, 2016

grzanka commented Jun 17, 2016

davidlange6 commented Jun 17, 2016

cmsbuild commented Jun 17, 2016 • edited

dmitrijus commented Jun 17, 2016

cmsbuild commented Jun 17, 2016

cmsbuild commented Jun 17, 2016

cmsbuild commented Jun 17, 2016

davidlange6 commented Jun 20, 2016

cmsbuild commented May 31, 2016 •

edited

cmsbuild commented Jun 17, 2016 •

edited