Change code to not stop on SRP block error and proceed with FE

[argiro]

Fix for a problem seen in run 274157 with corrupted SRP block from EB-11 FED.
The SRP block will be ignored, the consequence on reconstruction will be that no recovery of bad channels will be attempted for that FED.
DQM is being updated to set an alarm in case this situation is encountered again

[cmsbuild]

A new Pull Request was created by @argiro for CMSSW_8_1_X.

It involves the following packages:

EventFilter/EcalRawToDigi

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13293/console

[slava77]

@argiro
please confirm that this will affect only data

Also "by that FED" you now mean any FED with SRP block issues? (the code is rather generic)

[argiro]

On 31 May 2016, at 23:12, Slava Krutelyov notifications@github.com wrote:

@argiro
please confirm that this will affect only data

confirmed

Also "by that FED" you now mean any FED with SRP block issues? (the code is rather generic)

correct. It occured in EB-11

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[cmsbuild]

+1
Tested at: 871cd7f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14712/13293/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14712/13293/summary.html

[cvuosalo]

+1

For #14712 871cd7f

Fix for handling corrupted ECAL SRP blocks. There should be no change in standard workflows.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-05-31-1100 show no significant differences, as expected. Extended tests of workflows 134.702_RunDoubleEG2015B, 134.703_RunDoubleMuon2015B, 134.705_RunMET2015B, 134.902_RunDoubleEG2015D, 134.903_RunDoubleMuon2015D, and 134.905_RunMET2015D with 200 events each against baseline CMSSW_8_1_0_pre6 also show no significant differences. A test of prompt reco of 200 events from dataset JetHT from run 274157 and lumi section 531, which is in the period when the corruption occurred, shows data missing for EB-11 in the baseline, while this data is restored by the PR. The restored data causes small changes to many downstream quantities as would be expected. Plots below show the restored data for EB-11.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar