New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unique_ptr, not auto_ptr, in Analysis #14714
Conversation
A new Pull Request was created by @wmtan for CMSSW_8_1_X. It involves the following packages: AnalysisAlgos/SiStripClusterInfoProducer @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Pull request #14714 was updated. @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
@wmtan - could you rebase this |
8784e2f
to
24c77f7
Compare
Pull request #14714 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
@davidlange6 This PR has been rebased at the request of David Lange |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
The last use of the deprecated std::auto_ptr in the CMS framework is the "put" interface for EDProducts, which also supports std::unique:ptr. This PR changes all put calls in most Analysis packages to use std::unique_ptr instead of std::auto_ptr. Some other instances of std::auto_ptr in Analysis may also have been changed to std::unique_ptr.
Not all Analysis packages are converted in this PR due to dependency issues. The remaining Analysis packages will be converted at a later time.