Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique_ptr, not auto_ptr, in Analysis #14714

Merged
merged 1 commit into from Jun 7, 2016

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jun 1, 2016

The last use of the deprecated std::auto_ptr in the CMS framework is the "put" interface for EDProducts, which also supports std::unique:ptr. This PR changes all put calls in most Analysis packages to use std::unique_ptr instead of std::auto_ptr. Some other instances of std::auto_ptr in Analysis may also have been changed to std::unique_ptr.
Not all Analysis packages are converted in this PR due to dependency issues. The remaining Analysis packages will be converted at a later time.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2016

A new Pull Request was created by @wmtan for CMSSW_8_1_X.

It involves the following packages:

AnalysisAlgos/SiStripClusterInfoProducer
AnalysisAlgos/TrackInfoProducer
DPGAnalysis/SiStripTools
EgammaAnalysis/ElectronTools
EgammaAnalysis/PhotonIDProducers
ElectroWeakAnalysis/Skimming
ElectroWeakAnalysis/Utilities
ElectroWeakAnalysis/WMuNu
ElectroWeakAnalysis/ZEE
ElectroWeakAnalysis/ZMuMu
HeavyFlavorAnalysis/Onia2MuMu
HeavyFlavorAnalysis/Skimming
JetMETCorrections/JetVertexAssociation
JetMETCorrections/Modules
JetMETCorrections/Type1MET
MuonAnalysis/MomentumScaleCalibration
MuonAnalysis/MuonAssociators
SUSYBSMAnalysis/HSCP
TopQuarkAnalysis/TopEventProducers
TopQuarkAnalysis/TopEventSelection
TopQuarkAnalysis/TopHitFit
TopQuarkAnalysis/TopJetCombination
TopQuarkAnalysis/TopKinFitter
TopQuarkAnalysis/TopPairBSM
TopQuarkAnalysis/TopTools

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @Sam-Harper, @kreczko, @battibass, @ahinzmann, @trocino, @rafaellopesdesa, @mmarionncern, @rappoccio, @jhgoh, @argiro, @jdolen, @nhanvtran, @HuguesBrun, @threus, @schoef, @mmusich, @abbiendi, @mariadalfonso, @bellan, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@wmtan
Copy link
Contributor Author

wmtan commented Jun 1, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13296/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2016

Pull request #14714 was updated. @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2016

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 1, 2016

+1

For #14714 8784e2f

Migration to replace deprecated auto_ptr with unique_ptr in analysis code. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-05-31-2300 show no significant differences, as expected.

@davidlange6
Copy link
Contributor

@wmtan - could you rebase this
thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2016

Pull request #14714 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

@wmtan
Copy link
Contributor Author

wmtan commented Jun 2, 2016

@davidlange6 This PR has been rebased at the request of David Lange

@wmtan
Copy link
Contributor Author

wmtan commented Jun 2, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13349/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2016

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 3, 2016

@cmsbuild please test
Comparisons got stuck in the Queued state

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13368/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2016

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 6, 2016

+1

For #14714 24c77f7

Second approval, after a rebase. New Jenkins tests are still OK.

@davidlange6 davidlange6 merged commit 42a00fd into cms-sw:CMSSW_8_1_X Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants