81X Workaround MT problem in HIPixelMedianVtxProducer #14724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_8_1_X. It involves the following packages: RecoHI/HiTracking @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
@Dr15Jones A typical traceback is this one, a common feature to the crashes observed seems to be the destructor sequence in the last thread - Thread 1. |
|
We are seeing a similar crash in the IB. We think it is a bug in ROOT. Possibly running valgrind using the helgrind tool might pinpoint the problem. [I'm on vacation for the next week.] |
|
valgrind with HI code may have issues if it links to CGAL. There is a bug in valgrind. |
|
Sorry, no - but somewhat less timing efficiency is better than crashing! |
|
+1 Converting HIPixelMedianVtxProducer from edm::stream to edm::one to avoid a very elusive multi-threading bug. There should be no change in monitored quantities. #14725 is the 80X version of this PR. The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-05-31-2300 show no significant differences, as expected. |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
|
The crash is from a data race in the TMinuit constructor, fix is here: https://sft.its.cern.ch/jira/browse/ROOT-8217 valgrind can be run on HI code by defining CGAL_DISABLE_ROUNDING_MATH_CHECK in RecoHI/HiJetAlgos/plugins/VoronoiAlgorithm.h (valgrind doesn't emulate the different rounding modes). However, helgrind doesn't find the problem, as it is ordered by a mutex (just ordered incorrectly), so it had to be found via more labor-intensive means. |
|
@dan131riley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
81X Workaround MT problem in HIPixelMedianVtxProducer