New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
81x: add pixel barycenter computation tool #14730
81x: add pixel barycenter computation tool #14730
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_1_X. It involves the following packages: Alignment/MillePedeAlignmentAlgorithm @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
@ghellwig yes, basically was an add-on from Gero Flucke to quickly derive the barycenter position, designed to be included in |
@mmusich ok, this means, in its current implementation it works only with MillePede, but in principal it could be generalized to use, let's say, the resulting sqlite file instead of the millepede.res file, right? |
For me it seems that the directory MillePedeAlignmentAlgorithm/macros/ contains only files related to MPS. Therefore TrackerAlignment/macros would sound a more consistent location. Does the depencency of MillePede cause difficulties in that location? |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Making available in release tool needed for Pixel barycenter computation:
https://twiki.cern.ch/twiki/bin/view/CMS/TkAlignmentPixelPosition
attn: @tlampen, @mschrode,
@ghellwig please comment if there is any other more suitable place to put this.