New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding BPH skim module #14775
Adding BPH skim module #14775
Conversation
A new Pull Request was created by @kfjack (Kai-Feng Chen) for CMSSW_8_1_X. It involves the following packages: Configuration/Skimming @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
||
# muons with trigger info | ||
from MuonAnalysis.MuonAssociators.patMuonsWithTrigger_cff import * | ||
selectedMuons = cms.EDFilter('PATMuonSelector', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kfjack - here and in the other modules in this skim I would ask that you change the name to be something less generic to avoid potential name clashes. This would affect selectedMuons, selectedTracks and PhotonCandidates.
thanks @kfjack |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
+1 |
@davidlange6 - Sure. Many thanks! Please help me to sign the 80X back port PR #14776, and I'll send the skim model to T0 for a relval test (Hopefully this is the right procedure...). |
no- i want the skim added in Configuration/PyReleaseValidation. Then we can do a simple test in the integration builds, followed by a relval, followed by tier0. I think its just a matter of adding this skim to a list in one of the workflows.
|
@kfjack I think David is referring to include the skim in a relval wf using runTheMatrix and send it as test. I'll get in touch with you for this |
@fabozzi Many thanks!! |
@kfjack @davidlange6 it seems that IB tests in 81X are OK |
Add the newly proposed skim module for BPH PAG into the CMSSW.