Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BPH skim module #14775

Merged
merged 2 commits into from Jun 14, 2016
Merged

Adding BPH skim module #14775

merged 2 commits into from Jun 14, 2016

Conversation

kfjack
Copy link
Contributor

@kfjack kfjack commented Jun 6, 2016

Add the newly proposed skim module for BPH PAG into the CMSSW.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2016

A new Pull Request was created by @kfjack (Kai-Feng Chen) for CMSSW_8_1_X.

It involves the following packages:

Configuration/Skimming

@cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@fabozzi
Copy link
Contributor

fabozzi commented Jun 6, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13371/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2016

@fabozzi
Copy link
Contributor

fabozzi commented Jun 6, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar


# muons with trigger info
from MuonAnalysis.MuonAssociators.patMuonsWithTrigger_cff import *
selectedMuons = cms.EDFilter('PATMuonSelector',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfjack - here and in the other modules in this skim I would ask that you change the name to be something less generic to avoid potential name clashes. This would affect selectedMuons, selectedTracks and PhotonCandidates.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

Pull request #14775 was updated. @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please check and sign again.

@davidlange6
Copy link
Contributor

thanks @kfjack

@kfjack
Copy link
Contributor Author

kfjack commented Jun 14, 2016

Hi everyone, I need the re-confirmation from you in order to merge this modification into the next release. (So does PR #14776) Many thanks! @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi

@fabozzi
Copy link
Contributor

fabozzi commented Jun 14, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13481/console

@cmsbuild
Copy link
Contributor

@fabozzi
Copy link
Contributor

fabozzi commented Jun 14, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14775/13481/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2

@davidlange6
Copy link
Contributor

+1
@kfjack - for 80x, please add this new skim to a relval test so we can check that it has no impact on other components (at least on the few event level)

@cmsbuild cmsbuild merged commit a62f3fb into cms-sw:CMSSW_8_1_X Jun 14, 2016
@kfjack
Copy link
Contributor Author

kfjack commented Jun 14, 2016

@davidlange6 - Sure. Many thanks! Please help me to sign the 80X back port PR #14776, and I'll send the skim model to T0 for a relval test (Hopefully this is the right procedure...).

@davidlange6
Copy link
Contributor

no- i want the skim added in Configuration/PyReleaseValidation. Then we can do a simple test in the integration builds, followed by a relval, followed by tier0. I think its just a matter of adding this skim to a list in one of the workflows.

On Jun 14, 2016, at 6:12 PM, Kai-Feng Chen notifications@github.com wrote:

@davidlange6 - Sure. Many thanks! Please help me to sign the 80X back port PR #14776, and I'll send the skim model to T0 for a relval test (Hopefully this is the right procedure...).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@fabozzi
Copy link
Contributor

fabozzi commented Jun 14, 2016

@kfjack I think David is referring to include the skim in a relval wf using runTheMatrix and send it as test. I'll get in touch with you for this

@fabozzi
Copy link
Contributor

fabozzi commented Jun 16, 2016

@kfjack I've included the skim in PR #14911

@kfjack
Copy link
Contributor Author

kfjack commented Jun 17, 2016

@fabozzi Many thanks!!

@fabozzi
Copy link
Contributor

fabozzi commented Jun 20, 2016

@kfjack @davidlange6 it seems that IB tests in 81X are OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants