Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED Errors vs FED ID 2D plot #14793

Merged
merged 3 commits into from Jul 5, 2016
Merged

FED Errors vs FED ID 2D plot #14793

merged 3 commits into from Jul 5, 2016

Conversation

threus
Copy link
Contributor

@threus threus commented Jun 7, 2016

Added 2D ME counting Strip FED errors for each FED ID.
Saved into SiStrip/ReadoutView.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

A new Pull Request was created by @threus for CMSSW_8_1_X.

It involves the following packages:

DQM/SiStripMonitorHardware

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

please test

Code looks fine. I will +1 after the tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13397/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

-1

Tested at: 07a840e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14793/13397/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
9.0 step3
runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
25.0 step3
runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

@threus
Copy link
Contributor Author

threus commented Jun 8, 2016

Is it a legitimate error? I had no crashes running whiteRabbit on Run1 data. Could you help me to understand what's wrong with setBinLabel, when it works for other workflows? Thanks.

@davidlange6
Copy link
Contributor

@theus - these look like real errors (I think they were also there in a previous pull request) - maybe @dmitrijus would understand the error?

@dmitrijus
Copy link
Contributor

please test

I don't. Restarted tests, let's see if this happens again.
Alternatively, just run the test manually, in your area:
runTheMatrix -l 25.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13432/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2016

-1

Tested at: 07a840e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14793/13432/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
1001.0 step2
runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log
134.911 step3
runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log
9.0 step3
runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

@threus
Copy link
Contributor Author

threus commented Jun 10, 2016

So now tests 1000.0 and 25.0 passed, while new others failed. Strange. Which test should I run to debug the problem, if at all? The PR is really simple: booking and filling a 2D plot with bin labels. Nothing fancy.

@dmitrijus
Copy link
Contributor

How big is the histogram you are creating? (in number of bins)
I will ping a few people, maybe they will have an idea...

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2016

-1

Tested at: cdcf7fe

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14793/13826/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step1

DAS Error

@threus
Copy link
Contributor Author

threus commented Jul 1, 2016

thanks @davidlange6 !
@dmitrijus, now that there is only a DAS error, should you retrigger the test or the crash can be safely ignored?

@boudoul
Copy link
Contributor

boudoul commented Jul 4, 2016

@dmitrijus PING

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13865/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2016

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14793/13865/summary.html

The workflows 1003.0, 1001.0, 1000.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@threus
Copy link
Contributor Author

threus commented Jul 5, 2016

thanks all!

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f878266 into cms-sw:CMSSW_8_1_X Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants