add abs(dxy) plot in tracking DQM #14822
Conversation
|
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_1_X. It involves the following packages: DQM/TrackingMonitor @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
| @@ -977,6 +987,7 @@ void TrackAnalyzer::analyze(const edm::Event& iEvent, const edm::EventSetup& iSe | |||
| const reco::BeamSpot& bs = *recoBeamSpotHandle; | |||
|
|
|||
| DistanceOfClosestApproachToBS -> Fill(track.dxy(bs.position())); | |||
| AbsDistanceOfClosestApproachToBS -> Fill(abs(track.dxy(bs.position()))); | |||
There was a problem hiding this comment.
@mtosi - please use std::abs
There was a problem hiding this comment.
indeed, look a bit binned at the moment
There was a problem hiding this comment.
in any case 120 bins are most probably more than enough...
cmsbuild
added
dqm-pending
pending-signatures
tests-pending
comparison-pending
and removed
tests-approved
labels
|
Pull request #14822 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
backport as well please. Hope we can get in next 8_0_X patch |
|
same updates have been already done in PR #14826 (80x) |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
add |dxy| plot to tracking DQM