New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New FastSim Hit Reconstruction Emulation #14843
Conversation
Rechit plugins
Merge 750pre1
+1 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@matt-komm - while reviewing the rest - we need to move all the root files to the external data areas. |
@iahmad-khan , can you please take care of it? |
@davidlange6 the root files in this PR has been deleted already and they are present in cms-data /FastSimulation-TrackingRecHitProducer |
@matt-komm , @iahmad-khan - the root files are still in the PR itself - so if they are now in externals, we need @matt-komm to remove them from the PR itself. Thanks! |
@davidlange6 I cannot see a data directory with files inside this PR anymore (https://github.com/matt-komm/cmssw/tree/hitmerging-master/FastSimulation/TrackingRecHitProducer); I also checked it out in a fresh IB and these old data files are also not there anymore - can you let me know how you spotted them after this commit c1943d8 ? |
Hi David With respect to root files, Cheers Lukas |
Whoops, my mistake! |
A new producer to emulate hit reconstruction for tracking in FastSim is introduced. It features
For comparisons, the old producer can still be used but will be removed in the future. Currently, merging of hits is still deactivated. This will be changed in a later PR.
Related presentations from the 2nd FastSim days (https://indico.cern.ch/event/473392/):