Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New FastSim Hit Reconstruction Emulation #14843

Merged
merged 129 commits into from Jul 9, 2016

Conversation

matt-komm
Copy link
Contributor

A new producer to emulate hit reconstruction for tracking in FastSim is introduced. It features

  • simple plugin-based interface to produce reconstructed hits
  • plugins can be restricted to certain DetIds
  • hits can be merged if SimHits are too close

For comparisons, the old producer can still be used but will be removed in the future. Currently, merging of hits is still deactivated. This will be changed in a later PR.

Related presentations from the 2nd FastSim days (https://indico.cern.ch/event/473392/):

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13694/console

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@matt-komm - while reviewing the rest - we need to move all the root files to the external data areas.
@smuzaffar @Degano @iahmad-khan

@smuzaffar
Copy link
Contributor

@iahmad-khan , can you please take care of it?

@iahmad-khan
Copy link
Contributor

@davidlange6 the root files in this PR has been deleted already and they are present in cms-data /FastSimulation-TrackingRecHitProducer

@davidlange6
Copy link
Contributor

@matt-komm , @iahmad-khan - the root files are still in the PR itself - so if they are now in externals, we need @matt-komm to remove them from the PR itself. Thanks!

@matt-komm
Copy link
Contributor Author

@davidlange6 I cannot see a data directory with files inside this PR anymore (https://github.com/matt-komm/cmssw/tree/hitmerging-master/FastSimulation/TrackingRecHitProducer); I also checked it out in a fresh IB and these old data files are also not there anymore - can you let me know how you spotted them after this commit c1943d8 ?

@lveldere
Copy link
Contributor

lveldere commented Jul 8, 2016

@davidlange6

Hi David

With respect to root files,
This pr only removes root files.
(check the "files chaged" for this pr)

Cheers

Lukas

@davidlange6
Copy link
Contributor

Whoops, my mistake!

@davidlange6 davidlange6 merged commit 03041ec into cms-sw:CMSSW_8_1_X Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants