Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP code update #14847

Merged
merged 1 commit into from Jun 28, 2016
Merged

EP code update #14847

merged 1 commit into from Jun 28, 2016

Conversation

BetterWang
Copy link
Contributor

Fix table in comment.
Fix eta range for 1st order tracker EP.
Fix 1st order EP momentum conserving weight.
This PR is meant to be integrated with #14819 for a reprocess of 2015 PbPb data with pixel tracks.
@mandrenguyen

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @BetterWang (Quan Wang) for CMSSW_7_5_X.

It involves the following packages:

RecoHI/HiEvtPlaneAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @yenjie, @kurtejung, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jun 11, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13460/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jun 14, 2016

+1

for #14847 f805fc7

  • code changes look OK: updates only in the event plane code
  • jenkins tests pass and comparisons with baseline show no difference
    • there are some random differences in correctedEnergyUncertainty in validateJR plots, which is due to a missing initialization that wasn't ported back from 76X/8X

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9458406 into cms-sw:CMSSW_7_5_X Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants