New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Phase2-hgx58 Validation code to check if layer # is correctly assigned #14868
Conversation
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: Validation/HGCalValidation @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
#include "CLHEP/Geometry/Point3D.h" | ||
#include "CLHEP/Geometry/Vector3D.h" | ||
#include "CLHEP/Units/GlobalSystemOfUnits.h" | ||
#include "CLHEP/Units/GlobalPhysicalConstants.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda - are these includes needed?
@bsunanda -otherwise, the title does not explain what this PR is. Please update it. |
double rho = zp*TMath::Tan(2.0*TMath::ATan(TMath::Exp(-cell.eta))); | ||
double xp = rho * TMath::Cos(cell.phi); //cm | ||
double yp = rho * TMath::Sin(cell.phi); //cm | ||
double xp = rho * TMath::Cos(cell.phi); //cm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know its not new code- but please change to native C++ cos sin here. Thx @bsunanda
Pull request #14868 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
@cmsbuild Please test |
@dmitrijus @davidlange6 Could you approve this yet again? |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Add a private validation tool
Try to resolve the issue raised by Paul on layer # vs z