HGCal "EM Scale" Calibrations

[lgray]

Change RecHit producer to generate hits that are calibrated (roughly) to the electromagnetic shower scale to produce some "human readable" rec hit energies and to provide an estimate of cluster energies during cluster building.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13502/console

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X.

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @argiro, @cseez, @pfs this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[lgray]

(FYI the unit test will fail since it is fixed in another PR)

[cmsbuild]

-1

Tested at: 2738606

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14877/13502/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14877/13502/summary.html

[slava77]

better remove than comment out, unless there's a good reason to keep.
Add a comment why still needed.

[slava77]

+1

for #14877 2738606

• code change is in line with description
• jenkins tests pass at compilation, the unit test failures are unrelated to this PR and are fixed in HGCal Digitizer update/bugfix: more accurate noise model #14872
• locally checked with 11024.0 to take this as an opportunity to add some basic monitoring
  Energies change from something small to something larger but still not clearly physical in majority (dominated by noise?)
  
  

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar