TriggerResultsFilter: migrate to L1 Stage2 (81x)

[fwyzard]

No description provided.

[fwyzard]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13506/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13514/console

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/L1TGlobal
HLTrigger/HLTcore
HLTrigger/HLTfilters

@perrotta, @cmsbuild, @Martin-Grunewald, @rekovic, @fwyzard, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[fwyzard]

forward port of #14878 , rebased on 8.1.x

[fwyzard]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13516/console

[cmsbuild]

Pull request #14879 was updated. @perrotta, @cmsbuild, @ghellwig, @cvuosalo, @fwyzard, @cerminar, @dmitrijus, @Martin-Grunewald, @rekovic, @franzoni, @slava77, @mmusich, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

-1

Tested at: 8f9f56f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14879/13516/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Utilities/StaticAnalyzers/src/CmsSupport.cpp 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Utilities/StaticAnalyzers/src/CatchAll.cpp 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Utilities/StaticAnalyzers/src/GlobalStaticChecker.cpp 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Calibration/IsolatedParticles/interface/eECALMatrix.h:38:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Calibration/IsolatedParticles/src/eECALMatrix.cc:1:
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-06-14-1100/src/Geometry/CaloTopology/interface/EcalTrigTowerConstituentsMap.h:51:18: error: 'multi_index_container' in namespace 'boost' does not name a template type
   typedef boost::multi_index_container<
                  ^
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-06-14-1100/src/Geometry/CaloTopology/interface/EcalTrigTowerConstituentsMap.h:59:11: error: 'EcalTowerMap' does not name a type
   typedef EcalTowerMap::nth_index<0>::type EcalTowerMap_by_DetId;
           ^


• Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                ^
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-06-14-1100/src/DataFormats/Luminosity/interface/LumiDetails.h:1:996: warning: null character ignored [-Wnull-character]


[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14879/13517/summary.html

[dmitrijus]

+1

[slava77]

There are quite a few empty HLT Btag plots now in wf 25202
see in
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_8_1_X_2016-06-14-1100+14879/14461/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/HLT_BTag_Discriminator.html

[slava77]

+1

for #14879 8f9f56f

• reco is minimally affected
• jenkins tests pass and reco products are unchanged; there are differences in HLT plots though. So, chances are this PR gets updated.

[fwyzard]

I don't expect to update this PR, though there may be a follow up from @silviodonato or xavier.coubez@cern.ch to recover the plots (if this PR is indeed the reason they are empty).

[slava77]

On 6/15/16 4:14 PM, Andrea Bocci wrote:

I don't expect to update this PR, though there may be a follow up from
@silviodonato https://github.com/silviodonato or xavier.coubez@cern.ch
mailto:xavier.coubez@cern.ch to recover the plots (if this PR is
indeed the reason they are empty).

the plots are not empty in the baseline.
So, it is due to this PR (but it could as well reveal a latent
bug/feature in modules making these plots)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14879 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/AEdcbgZOjFDsVCDx5zMjlYEsZGOAddR0ks5qMIdogaJpZM4I1hdI.

[silviodonato]

Ciao,
the release validation plots of HLT BTagging are ok in 81X ( https://goo.gl/KGmS4D ).
Perhaps the problem is related with the TriggerResults in https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/HLTriggerOffline/Btag/src/HLTBTagPerformanceAnalyzer.cc , but I don't understand how ...

[mulhearn]

+1

[Martin-Grunewald]

@mmusich
Please sign also this one!

[mmusich]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1