Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PUPPI configuration parameters. #14901

Merged
merged 1 commit into from Jun 20, 2016
Merged

Update PUPPI configuration parameters. #14901

merged 1 commit into from Jun 20, 2016

Conversation

hsatoshi
Copy link
Contributor

PUPPI configuration parameter has been updated.
The PT threshold on neutral particles in the region |eta|=3-10 is now set to the same value as 76x tuning.

Mentioned at a meeting :
https://indico.cern.ch/event/537458/

@nhanvtran @violatingcp

PUPPI configuration parameter has been updated.
The PT threshold on neutral particles in the region |eta|=3-10 is now set to the same value as 76x tuning.

Mentioned at a meeting : 
https://indico.cern.ch/event/537458/
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hsatoshi for CMSSW_8_1_X.

It involves the following packages:

CommonTools/PileupAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13545/console

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

-1

Tested at: 43d4909

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a513230
5afa7e7
8b79e69
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14901/13545/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14901/13545/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14901/13545/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found an error when building:

Entering library rule at src/DQMServices/FwkIO/plugins
Entering library rule at src/DQMServices/Core/test
Entering library rule at CalibCalorimetry/HcalTPGAlgos
>> Leaving Package Configuration/PyReleaseValidation
>> Package Configuration/PyReleaseValidation built
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/PhysicsTools/MVATrainer/src/XMLDocument.cc:17:43: fatal error: xercesc/dom/DOMLSSerializer.hpp: No such file or directory
compilation terminated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/GeneratorInterface/LHEInterface/test/DummyLHEAnalyzer.cc 
Entering library rule at GeneratorInterface/LHEInterface
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/FWCore/Concurrency/src/SerialTaskQueue.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/FWCore/Concurrency/src/SharedResourceNames.cc 

  • Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 64 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

Selected class -> TCell for ROOT: TCell
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/DetectorDescription/Core/src/DDRotation.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/DetectorDescription/Core/src/LogicalPart.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/DetectorDescription/Core/src/EllipticalTube.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/DetectorDescription/Core/src/Boolean.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/PhysicsTools/MVATrainer/src/XMLDocument.cc:17:10: fatal error: 'xercesc/dom/DOMLSSerializer.hpp' file not found
#include 
         ^
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/DetectorDescription/Core/src/DDConstant.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/DetectorDescription/Core/src/DDdummy.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-15-2300/src/Calibration/HcalCalibAlgos/src/HcalConstantsXMLWriter.cc:16:


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a513230
5afa7e7
8b79e69
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14901/13545/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14901/13545/git-merge-result

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2016

simple updates don't need to be rebased to the head of a development branch.
this PR tests will have to wait until a new IB comes out.

@hsatoshi
Copy link
Contributor Author

I am sorry for naive questions.
What I have been supposed to do,
and what can I do this time ?

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2016

On 6/16/16 6:47 AM, hsatoshi wrote:

I am sorry for naive questions.
What I have been supposed to do,
and what can I do this time ?

nothing to do now.

Just use an existing release , git checkout -b , git push

from the context it looks like you added git checkout CMSSW_8_1_X or
something like
http://cms-sw.github.io/faq.html#how-do-i-make-sure-my-topic-branch-is-updated-with-the-latest-developments


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14901 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/AEdcbt5csFsLXnqtURalg8flPNIX12_3ks5qMVPegaJpZM4I3O6N.

@hsatoshi
Copy link
Contributor Author

Thank you.

Shall we withdraw this PR and send another PR based on some release (is CMSSW_8_1_0_pre7 a good one ?)
or will this PR be taken into account (semi)automatically at some point?

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2016

On 6/16/16 7:16 AM, hsatoshi wrote:

Thank you.

Shall we withdraw this PR and send another PR based on some release (is
CMSSW_8_1_0_pre7 a good one ?)
or will this PR be taken into account (semi)automatically at some point?

as I said already, do nothing this time.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14901 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/AEdcbm4yOnen4AhPStrrk4fojBrlVDTkks5qMVrKgaJpZM4I3O6N.

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2016

@cmsbuild please test
new IB is out, although in other PRs there were build errors due to cvmfs. So, chances are the tests can fail for another reason.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13563/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jun 18, 2016

+1

for #14901 43d4909

  • changes are only in the configuration, in line with the description
  • jenkins tests pass and show differences only in PUPPI-related quantities
  • Looking at wf 25202 (ttbar with PU35, using 810pre6 relval RECO as input) with ~3K events processed to get better stats, changes are roughly as expected.

fairly significant change in puppi jets up to pt 40 GeV, expected from the increased thresholds
all_test14901-patvsorig-pat_ttbarpuwf25202p0c_log10patjets_slimmedjetspuppi__dqm_obj_et
mostly in the HF region
all_test14901-patvsorig-pat_ttbarpuwf25202p0c_patjets_slimmedjetspuppi__dqm_obj_eta

jet response is down, but this will be corrected back
wf25202_pupj_ptcorovergen_eta

jet mass is down as well in the forward by apparently a bit more than the jet response. This may need a follow up.
wf25202_pupj_f_mrecovergen

puppi MET is almost unchanged by value; sumET decreases and non-HF fractions increase due to decrease of the HF contribution (expected)

@davidlange6 davidlange6 merged commit 04338df into cms-sw:CMSSW_8_1_X Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants