Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tracking hit effiicency vs BX on relval (data workflows only) #14915

Merged
merged 3 commits into from Jun 20, 2016

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jun 17, 2016

this update adds the hit efficiency vs BX on data relval workflows (and all PDs)
@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_1_X.

It involves the following packages:

DQM/TrackingMonitorSource
DQMOffline/Configuration

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @threus, @fioriNTU, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jun 17, 2016

@mtosi
what's the memory increase from this?
3564 bins x the number of different types of histograms can become large.

@mtosi
Copy link
Contributor Author

mtosi commented Jun 17, 2016

citing @rovere (thanks)
1 histo w/ 3600 bins --> 3600 x 8bytes ~ 4k x 8 = 32 kB
there are 1 histo per partitions x (type of hit + eff)
there are 27 partitions => 135 histos + 27 histos = 162 histos
=> ~5MB

@slava77
Copy link
Contributor

slava77 commented Jun 17, 2016

Sumw2 is never called, right?
it will add 16 bytes per bin.

@mtosi
Copy link
Contributor Author

mtosi commented Jun 17, 2016

=> 15MB ?

@rovere
Copy link
Contributor

rovere commented Jun 17, 2016

Not locally, not sure globally (i.e. via static member functions, e.g. https://root.cern.ch/doc/master/TH1_8cxx_source.html#l06247)

@slava77
Copy link
Contributor

slava77 commented Jun 17, 2016

On 6/17/16 8:17 AM, mia tosi wrote:

=> 15MB ?

sounds small.
I suppose there is only one instance of the monitoring module doing it.
Please confirm.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14915 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/AEdcbmNc2opT70oc8ck47YUPYEl3NrZEks5qMrpugaJpZM4I4XMD.

@rovere
Copy link
Contributor

rovere commented Jun 17, 2016

One instance per stream, you mean, right?
I let Mia comment for how many selected-track-collection we do have the monitoring enabled, since those counts separately as instances, if that's what you are asking for.

@mtosi
Copy link
Contributor Author

mtosi commented Jun 17, 2016

generalTracks and HP tracks w/ pT > 1 GeV
if tracking POG agrees, I can limit these plots to HP w/ pT > 1

@rovere
Copy link
Contributor

rovere commented Jun 17, 2016

Ok, for vs BX enable only HP, pt >1

@mtosi
Copy link
Contributor Author

mtosi commented Jun 17, 2016

I'm going to update the PRs, thus

@cmsbuild
Copy link
Contributor

Pull request #14915 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #14915 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@VinInn
Copy link
Contributor

VinInn commented Jun 19, 2016

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13584/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2219f8c into cms-sw:CMSSW_8_1_X Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants