Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOMCount to Xerces 3x #14917

Merged
merged 1 commit into from Jun 22, 2016
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jun 17, 2016

A copy of Xerces example used for validation tests

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

DetectorDescription/RegressionTest

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@ianna
Copy link
Contributor Author

ianna commented Jun 17, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13579/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 5887453

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14917/13579/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test DetectorDescriptionRegressionTestDOMCount had ERRORS

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor Author

ianna commented Jun 17, 2016

The error is fixed by #14906

@ianna
Copy link
Contributor Author

ianna commented Jun 21, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13605/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor Author

ianna commented Jun 22, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4f19f63 into cms-sw:CMSSW_8_1_X Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants