Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fpix HitEfficiency Maps per Panel #14927

Merged

Conversation

minano
Copy link
Contributor

@minano minano commented Jun 20, 2016

Now for CMSSW_8_0_X: 1. The monitor elements for Endcap: meMissingBlade_ and meValidBlade_ are now filled per panel. This allows to plot the HitEfficiency maps with more Granularity. The Hit Efficiency is showed per blade and panel for every endcap disk. 2. Functions getBlade and getLadder to read the Blade and Ladder with no dependence on detector geometry. Reducing existing hard code.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @minano (Mercedes Miñano Moya) for CMSSW_8_0_X.

It involves the following packages:

DQM/SiPixelMonitorClient
DQM/SiPixelMonitorTrack

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @fioriNTU this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

Is there a PR for 81x?

@minano
Copy link
Contributor Author

minano commented Jun 21, 2016

Yes, there is. PR: #14801

@dmitrijus
Copy link
Contributor

dmitrijus commented Jun 21, 2016

Which is not the same as this one and is twice as large (?)

@minano
Copy link
Contributor Author

minano commented Jun 21, 2016

True. This PR is including the modifications of PR #14801 about Fpix HitEfficiency plots and PR #14328 adding getBlade and getLadder functions.

@dmitrijus
Copy link
Contributor

+1

It is better (and faster) if PR between releases are matched....

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13604/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants