Fix problem with FH hits not getting correct dE/dX normalizations.

[lgray]

Layer number was resetting for FH layers, requires offset.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13603/console

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X.

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @argiro, @cseez, @pfs this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[cmsbuild]

-1

Tested at: 4bb8f05

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14932/13603/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14932/13603/summary.html

[slava77]

+1

for #14932 4bb8f05

• code change is as described, affects only 2023 workflows with HGCAL
• jenkins tests pass (2023 workflows are not a part of comparisons)
• locally tested with 11024 and 11021: HGC HEF hit energies change and now on the extreme high side look like normal response.
  Here is a plot from 11024 (ttbar)
  

@lgray is the population at the very low end after some reasonable zero suppression?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[lgray]

@slava77 The population at the low end is cutting at 2 x noise x thickness, so a reasonable zero suppression, except for the 100um thick sensors where you start to eat a bit of the noise since you're only two sigma out. It is under discussion if we are going to make this cut harder.