Changing linkage of the "timeshift_ns_hbheho" function to external #14957
Conversation
|
A new Pull Request was created by @igv4321 (Igor Volobouev) for CMSSW_8_1_X. It involves the following packages: RecoLocalCalo/HcalRecAlgos @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #14957 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| float timeshift_ns_hbheho(float wpksamp); | ||
|
|
||
| /// Special energy correction for some HB- cells | ||
| float hbminus_special_ecorr(int ieta, int iphi, double energy, int runnum); |
There was a problem hiding this comment.
since there are two methods declared here now, the timeshift_ns_hbheho.h file name is no longer intuitive.
Please rename to something more comprising.
There was a problem hiding this comment.
I have no idea what is intuitive for you. It is intuitive enough for me.
If you want it renamed, suggest a name.
On 06/26/2016 11:06 AM, Slava Krutelyov wrote:
In RecoLocalCalo/HcalRecAlgos/interface/timeshift_ns_hbheho.h #14957 (comment):
@@ -0,0 +1,14 @@
+#ifndef RecoLocalCalo_HcalRecAlgos_timeshift_ns_hbheho_h_
+#define RecoLocalCalo_HcalRecAlgos_timeshift_ns_hbheho_h_
+
+///Timeshift correction for HPDs based on the position of the peak ADC measurement.
+/// Allows for an accurate determination of the relative phase of the pulse shape from
+/// the HPD. Calculated based on a weighted sum of the -1,0,+1 samples relative to the peak
+/// as follows: wpksamp = (0_sample[0] + 1_sample[1] + 2*sample[2]) / (sample[0] + sample[1] + sample[2])
+/// where sample[1] is the maximum ADC sample value.
+float timeshift_ns_hbheho(float wpksamp);
+
+/// Special energy correction for some HB- cells
+float hbminus_special_ecorr(int ieta, int iphi, double energy, int runnum);since there are two methods declared here now, the timeshift_ns_hbheho.h file name is no longer intuitive.
Please rename to something more comprising.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/cms-sw/cmssw/pull/14957/files/0f0937650a7012d4c9a9a387e9ebb0997eb4842c#r68505180, or mute the thread
https://github.com/notifications/unsubscribe/AFS4-ciRrWqRBHpzU8FAYDSB32ivTLTfks5qPqN2gaJpZM4I8hdG.
There was a problem hiding this comment.
a file named timeshift containing energy correction is not intuitive.
CorrectionFunctions.h may be well covering what's here.
There was a problem hiding this comment.
Fine. Renamed into HcalCorrectionFunctions.h
On 06/26/2016 12:38 PM, Slava Krutelyov wrote:
In RecoLocalCalo/HcalRecAlgos/interface/timeshift_ns_hbheho.h #14957 (comment):
@@ -0,0 +1,14 @@
+#ifndef RecoLocalCalo_HcalRecAlgos_timeshift_ns_hbheho_h_
+#define RecoLocalCalo_HcalRecAlgos_timeshift_ns_hbheho_h_
+
+///Timeshift correction for HPDs based on the position of the peak ADC measurement.
+/// Allows for an accurate determination of the relative phase of the pulse shape from
+/// the HPD. Calculated based on a weighted sum of the -1,0,+1 samples relative to the peak
+/// as follows: wpksamp = (0_sample[0] + 1_sample[1] + 2*sample[2]) / (sample[0] + sample[1] + sample[2])
+/// where sample[1] is the maximum ADC sample value.
+float timeshift_ns_hbheho(float wpksamp);
+
+/// Special energy correction for some HB- cells
+float hbminus_special_ecorr(int ieta, int iphi, double energy, int runnum);a file named timeshift containing energy correction is not intuitive.
CorrectionFunctions.h may be well covering what's here.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/cms-sw/cmssw/pull/14957/files/0f0937650a7012d4c9a9a387e9ebb0997eb4842c#r68506304, or mute the thread
https://github.com/notifications/unsubscribe/AFS4-QiZlp5TynSgw4i4oQb5CLYCC_g-ks5qPrj-gaJpZM4I8hdG.
|
Pull request #14957 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
Pull request #14957 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-approved
comparison-pending
and removed
comparison-available
tests-started
labels
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
@davidlange6 Please merge, there is more code in the pipeline depending on this change. |
|
+1 |
A trivial change, in the anticipation of Phase 1 algorithm development.
Not expected to affect anything.