Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce PCL disk space 81X #14961

Merged
merged 3 commits into from Jun 28, 2016
Merged

Reduce PCL disk space 81X #14961

merged 3 commits into from Jun 28, 2016

Conversation

ghellwig
Copy link

Reduces size of binaries written to disk in the harvesting step of the SiPixelAli to 30% of it's original size.
Addresses issue reported in Tier-0 Operations HN.

@gregor-mittag
Write compressed binaries to disk in 'MillePedeFileExtractor'.
25e9ae6
@gregor-mittag
Keep measurements without global derivatives.
f5e1acd 
 - previously all hits without alignables defined for their subdetector
   were discarded
 - now these hits are kept by default because they are used in the
   'pede'-internaltrack fit and to define the reference frame
   -> desired default behaviour
 - a switch has been added to revert to the old behaviour
   -> useful if one wants to mask certain parts of the tracker
@gregor-mittag
Reduce PCL Mille binary size by dropping fixed alignables.
349fe71
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Jun 23, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_8_1_X.

It involves the following packages:

Alignment/CommonAlignmentProducer
Alignment/MillePedeAlignmentAlgorithm

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@ghellwig ghellwig mentioned this pull request Jun 23, 2016
Merged
@ghellwig
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 23, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13646/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 349fe71

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fe77176
3ea37df
a38c0f3
b9e0f91
861f8e2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14961/13646/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14961/13646/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14961/13646/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
25202.0 step3 
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
4.22 step1 
DAS Error
136.731 step1 
DAS Error
140.53 step1 
DAS Error
1000.0 step1 
DAS Error
1001.0 step1 
DAS Error
1003.0 step1 
DAS Error

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fe77176
3ea37df
a38c0f3
b9e0f91
861f8e2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14961/13646/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14961/13646/git-merge-result

@mmusich
Copy link
Contributor

mmusich commented Jun 24, 2016

@ghellwig the error in 50202.0 step2 and in 25202.0 step3

are not related to this PR:

----- Begin Fatal Exception 23-Jun-2016 19:42:51 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

@ghellwig
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13655/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 349fe71
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14961/13655/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14961/13655/summary.html

@mmusich
Copy link
Contributor

mmusich commented Jun 27, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4ba3315 into cms-sw:CMSSW_8_1_X Jun 28, 2016
@ghellwig ghellwig deleted the reduce-PCL-disk-space_81X branch June 28, 2016 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ghellwig @cmsbuild @mmusich @davidlange6 @gregor-mittag