Adding Layer number to bad module list #14969
Conversation
|
A new Pull Request was created by @fioriNTU for CMSSW_8_1_X. It involves the following packages: DQM/SiStripMonitorClient @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
| @@ -363,8 +363,10 @@ void SiStripTrackerMapCreator::paintTkMapFromAlarm(uint32_t det_id, const Tracke | |||
| if(isBad) { rval=255; gval=255; bval = 0; comment << " PCLBadModule ";} | |||
| trackerMap_->setText(det_id, comment.str()); | |||
| trackerMap_->fillc(det_id, rval, gval, bval); | |||
| if(badmodmap && (flag!=0 || isBad)) (*badmodmap)[det_id] = comment.str(); | |||
|
|
|||
| uint lay= tTopo->layer(SiStripDetId(det_id)); | |||
There was a problem hiding this comment.
@fioriNTU - please put all three lines into the if statement. 'lay' and 'layer' are needed only in the if
cmsbuild
added
dqm-pending
pending-signatures
tests-pending
comparison-pending
and removed
tests-approved
labels
|
Pull request #14969 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
corrspondent to #14970 in 81X, this PR adds the layer number to a log file with a list of "bad modules" id. Used by Tracker Offline shifters