Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety fix for MagneticField/Engine: Member data modified in const function #1497

Merged
merged 1 commit into from Nov 20, 2013
Merged

Thread safety fix for MagneticField/Engine: Member data modified in const function #1497

merged 1 commit into from Nov 20, 2013

Conversation

smuzaffar
Copy link
Contributor

use of atomic to avoid

  • Member data modified in const function

Static analyzer will still report it as mutable member are still needed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_7_0_X.

Thread safety fix for MagneticField/Engine: Member data modified in const function

It involves the following packages:

TrackingTools/TrajectoryState
TrackingTools/MaterialEffects
TrackingTools/TrajectoryParametrization
RecoTracker/TkSeedGenerator
MagneticField/Engine

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc, @cerati, @ghellwig, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Nov 20, 2013

+1
Tested 172f652 in CMSSW_7_0_X_2013-11-19-0200-1497
No difference in reco as expected, based on RelMon and reco script

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 20, 2013
…ld-Engine

Multithreading fixes -- MagneticField/Engine:  Member data modified in const function
@ktf ktf merged commit d9a92a1 into cms-sw:CMSSW_7_0_X Nov 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants