Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against negative occupancy thresholds #14979

Merged
merged 1 commit into from Jun 28, 2016

Conversation

mbandrews
Copy link
Contributor

Modify quality threshold for cases where we see vanishing occupancy:

  • Originally: if Entries in a FED < overall FED mean - 5*overall FED rms => set Occupancy Quality to RED
  • However, if occupancy is exactly zero, the rms tends to be quite large and the overall FED mean < 5*overall FED rms, so the threshold occupancy < 0. This was seen, for instance, in collisions run 275766, where the Emulation Quality continued to show YELLOW
  • To protect against these cases (without tightening the 5 sigma constraint), if threshold occupancy < 0, set threshold occupancy to 10.

In conjunction with 80X PR #14978.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbandrews (Michael Andrews) for CMSSW_8_1_X.

It involves the following packages:

DQM/EcalMonitorClient

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13684/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f43d716 into cms-sw:CMSSW_8_1_X Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants