PR 81X Fix sporadic crashes in HLT when Seeding with correlations. #14992
Conversation
…gers: was looping both over types and over vector SingleCombinationInCondition. Now loop over vector SingleCombinationInCondition and increase iType counter.
|
A new Pull Request was created by @rekovic for CMSSW_8_1_X. It involves the following packages: HLTrigger/HLTfilters @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@rekovic |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
hlt-approved
fully-signed
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
Comparison is ready There are some workflows for which there are errors in the baseline: |
…using std::distance in SingleCombinationInCondition vector iterator.
cmsbuild
added
hlt-pending
pending-signatures
tests-pending
comparison-pending
and removed
tests-approved
labels
|
Pull request #14992 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again. |
|
Pull request #14992 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
hlt-approved
fully-signed
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
This is a fix for the sporadic crashes in the HLT in case of L1T correlation triggers are used.
The problem was in the HLTL1TSeed module which was making ghost combinations in case of cross-object triggers. What effectively was a double loop (once over the vector SingleCombinationInCondition and once over the object types) was causing seeding combinations to be n^2, where n is the larger number of seeds of the two object types. Some of the objects of the type with smaller number of passing objects were not necessarily passing the L1T conditions but were still being promoted as seeds, creating ghosts.
The code was previously looping both over object types and over vector SingleCombinationInCondition.
This is fixed by now only looping over SingleCombinationInCondition while tracking the object
type to seed properly.