Validation/RecoParticleFlow : gcc 6.0 misleading-indentation warning flags potential bug; with bug fix #14999
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X. It involves the following packages: Validation/RecoParticleFlow @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 Tested at: 439b47f You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log4.22 step1 DAS Error136.731 step1 DAS Error140.53 step1 DAS Error1000.0 step1 DAS Error1001.0 step1 DAS Error1003.0 step1 DAS Error |
gartung
changed the title
| @@ -89,8 +89,10 @@ void PlotCompareUtility::makePlots<Plot1D>(HistoData *HD) { | |||
|
|
|||
| // place the test results as the title | |||
| TString title = HD->getName(); | |||
| if (ksThreshold > 0) title += " KS Score = "; title += HD->getKSScore(); | |||
There was a problem hiding this comment.
Did the author intend for these two statements to be enclosed in curly braces?
cmsbuild
added
dqm-pending
pending-signatures
and removed
dqm-approved
fully-signed
tests-rejected
labels
|
Pull request #14999 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
gartung
changed the title
|
+1 |
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/Validation/RecoParticleFlow/bin/include/Plot1D.h: In member function 'void PlotCompareUtility::makePlots(HistoData*) [with int PlotType = 0]':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/Validation/RecoParticleFlow/bin/include/Plot1D.h:92:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (ksThreshold > 0) title += " KS Score = "; title += HD->getKSScore();
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/Validation/RecoParticleFlow/bin/include/Plot1D.h:92:49: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
if (ksThreshold > 0) title += " KS Score = "; title += HD->getKSScore();
^~~~~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/Validation/RecoParticleFlow/bin/include/Plot1D.h:93:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (chi2Threshold > 0) title += " Chi^2 Score = "; title += HD->getChi2Score();
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/Validation/RecoParticleFlow/bin/include/Plot1D.h:93:54: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
if (chi2Threshold > 0) title += " Chi^2 Score = "; title += HD->getChi2Score();
^~~~~