Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature in GEM simulation: GEMPadDigiCluster #15001

Merged
merged 5 commits into from Jun 29, 2016
Merged

New feature in GEM simulation: GEMPadDigiCluster #15001

merged 5 commits into from Jun 29, 2016

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Jun 27, 2016

A GEMPadDigiCluster is a set of adjacent GEMPadDigis in a single GEM chamber. Currently we send all trigger pads from the GEM chamber to the CSC chamber. In the hardware each GEM chamber optohybrid will send at most 8 clusters of at most 8 adjacent trigger pads to the nearby CSC optical trigger mother board. The effects are expected to be very small (<1%) on the local GEM-CSC trigger performance.

Still needs to be done: use GEMPadDigiClusters instead of GEMPadDigis in CSC trigger emulator.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/GEMDigi
SimMuon/Configuration
SimMuon/GEMDigitizer

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@abbiendi, @trocino, @HuguesBrun, @jhgoh, @battibass this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jun 27, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13711/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@dildick
Copy link
Contributor Author

dildick commented Jun 28, 2016

Comparison looks good. There should not be (and there aren't) any changes with respect to the baseline.

@civanch
Copy link
Contributor

civanch commented Jun 28, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2f48177 into cms-sw:CMSSW_8_1_X Jun 29, 2016
@dildick dildick deleted the from-CMSSW_8_1_0_pre7-GEMPadDigiClusterizer branch October 20, 2016 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants