CalibCalorimetry/CaloTPG :formatting fix for gcc 6.0 misleading-indentation warning #15002
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X. It involves the following packages: CalibCalorimetry/CaloTPG @ghellwig, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
@gartung can you clarify the intention of splitting the change into two commits? |
|
My initial commit added the curly braces, but I did not want to change the meaning of the code. |
|
+1 |
gartung
changed the title
| @@ -60,7 +60,7 @@ void CaloTPGTranscoderULUT::loadHCALCompress(HcalLutMetadata const& lutMetadata, | |||
| (not HcalGenericDetId(*i).isHcalZDCDetId()) and | |||
| (not HcalGenericDetId(*i).isHcalCastorDetId())) | |||
| edm::LogWarning("CaloTPGTranscoderULUT") << "Encountered invalid HcalDetId " << HcalGenericDetId(*i); | |||
| continue; | |||
There was a problem hiding this comment.
Is this continue meant to be in the if block started on line 59?
gartung
changed the title
gartung
changed the title
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc:59:4: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if ((not HcalGenericDetId(*i).isHcalDetId()) and
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc:63:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
continue;
^~~~~~~~