SimG4CMS/FP420 : gcc 6.0 misleading-indentation warning flags potential bug; with formatting fix #15004
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X. It involves the following packages: SimG4CMS/FP420 @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@gartung , if fix why not use {} for all places where there are problems? |
gartung
changed the title
| std::cout << "FP420Test: My warning: NumberOfPrimaryVertex != 1 --> = " << nvertex << std::endl; | ||
|
|
||
| for (int i = 0 ; i<nvertex; i++) { |
There was a problem hiding this comment.
Is this for loop mean to be in the if block?
|
please test |
|
The tests are being triggered in jenkins. |
gartung
changed the title
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/SimG4CMS/FP420/plugins/FP420Test.cc:956:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (nvertex !=1)
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/SimG4CMS/FP420/plugins/FP420Test.cc:959:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
for (int i = 0 ; i<nvertex; i++) {
^~~