Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress LogError for somewhat clearly bad input of TrajectoryStateCombiner (backport of #15016) #15017

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jun 28, 2016

[copy-pasted message from #15016]
demote TrajectoryStateCombiner::combiner MatrixInversionFailure issue to LogWarning for all and issue no message for somewhat clearly bad inputs.

Fairly frequent LogErrors from MatrixInversionFailure category in module StandAloneMuonProducer:standAloneSETMuons

In my test I re-recoed about 5K events from Run2016B/MET/RAW-RECO/LogError-PromptReco-v2 runs (fractionally) 274241,274244,274250,274251,274282 for a total of 166 LS.

This error happened 641 times (some repeated multiple times in event)
and all of the cases were for a transformation of a seed with TSOS with 0 error values in in q/p row/column. This is clearly not invertible.

Maybe in the long run there should be a change in logic of the algorithm.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_0_X.

It involves the following packages:

TrackingTools/TrackFitters

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @bellan, @HuguesBrun, @rovere, @gpetruc, @trocino, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor Author

slava77 commented Jun 28, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13748/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented Jul 1, 2016

+1

for #15017 340444c

  • jenkins tests pass and show no differences (the affected logErrors are not frequent enough to show up in the tests)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants