New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suppress LogError for somewhat clearly bad input of TrajectoryStateCombiner (backport of #15016) #15017
suppress LogError for somewhat clearly bad input of TrajectoryStateCombiner (backport of #15016) #15017
Conversation
A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_0_X. It involves the following packages: TrackingTools/TrackFitters @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
[copy-pasted message from #15016]
demote TrajectoryStateCombiner::combiner MatrixInversionFailure issue to LogWarning for all and issue no message for somewhat clearly bad inputs.
Fairly frequent LogErrors from MatrixInversionFailure category in module StandAloneMuonProducer:standAloneSETMuons
In my test I re-recoed about 5K events from Run2016B/MET/RAW-RECO/LogError-PromptReco-v2 runs (fractionally) 274241,274244,274250,274251,274282 for a total of 166 LS.
This error happened 641 times (some repeated multiple times in event)
and all of the cases were for a transformation of a seed with TSOS with 0 error values in in q/p row/column. This is clearly not invertible.
Maybe in the long run there should be a change in logic of the algorithm.